Attention is currently required from: laforge.

View Change

2 comments:

• File pySim/card_key_provider.py:

  • Patch Set #1, Line 337: def argparse_add_card_key_provider_args(arg_parser: argparse.ArgumentParser):

    to be consistent with other methods I would call it card_key_provider_argparse_add_args or something […]

    I took the scheme from pySim/transport/__init__.py. There we use the prefixes argparse_add_ and init_. But I see, there is already card_key_provider_register. Now everything falls apart. I would say the consistency inside the file weighs more then the consistency throughout modules.

  • Patch Set #1, Line 344: init_card_key_provider

    likewise here I'd call it card_key_provider_init similar to card_key_provider_{get,get_field} above

    Yes, let's use the card_key_provider_ prefix.

To view, visit change 42734. To unsubscribe, or for help writing mail filters, visit settings.