Attention is currently required from: fixeria, laforge, pespin.

View Change

4 comments:

• File src/osmo-bsc/system_information.c:

  • Patch Set #6, Line 1420: int gsm_generate_si10(uint8_t *data, size_t len, const struct gsm_subscriber_connection *conn)

    "struct gsm48_system_information_type_10 *data" ?

    Done

  • Patch Set #6, Line 1424: struct gsm_bts *s_bts = conn->lchan->ts->trx->bts;

    Can conn->lchan be null? […]

    It can't, because in NULL case, gsm_generate_si10() is not called. This is checked right before calling gsm_generate_si10() in si10_update().

• File src/osmo-bsc/vgcs_fsm.c:

  • Patch Set #6, Line 70: #define SI10_TIMER 3, 0

    AFAIU this is no longer used.

    Done

  • Patch Set #6, Line 71: #define SI10_LENGTH 21

    this length should be in the same header where the API is used, and probably be documented in the AP […]

    Done

To view, visit change 34626. To unsubscribe, or for help writing mail filters, visit settings.