laforge submitted this change.

View Change

Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved
icE1usb fw: Use 'int' as the default type for port index

No benefit to use uint8_t and for consistency with later patches,
use 'int' here too.

Signed-off-by: Sylvain Munaut <tnt@246tNt.com>
Change-Id: I50a76476af844acf20436b9d410cb917b723590d
---
M firmware/ice40-riscv/icE1usb/e1.h
M firmware/ice40-riscv/icE1usb/misc.c
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/firmware/ice40-riscv/icE1usb/e1.h b/firmware/ice40-riscv/icE1usb/e1.h
index 9ceffdd..862d568 100644
--- a/firmware/ice40-riscv/icE1usb/e1.h
+++ b/firmware/ice40-riscv/icE1usb/e1.h
@@ -57,5 +57,5 @@
E1P_LED_ST_BLINK_FAST = 3
};

-extern void e1_platform_led_set(uint8_t port, enum e1_platform_led led,
+extern void e1_platform_led_set(int port, enum e1_platform_led led,
enum e1_platform_led_state state);
diff --git a/firmware/ice40-riscv/icE1usb/misc.c b/firmware/ice40-riscv/icE1usb/misc.c
index 3117be9..a25bcc5 100644
--- a/firmware/ice40-riscv/icE1usb/misc.c
+++ b/firmware/ice40-riscv/icE1usb/misc.c
@@ -53,7 +53,7 @@
}

void
-e1_platform_led_set(uint8_t port, enum e1_platform_led led,
+e1_platform_led_set(int port, enum e1_platform_led led,
enum e1_platform_led_state state)
{
uint32_t tmp;

To view, visit change 26837. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmo-e1-hardware
Gerrit-Branch: master
Gerrit-Change-Id: I50a76476af844acf20436b9d410cb917b723590d
Gerrit-Change-Number: 26837
Gerrit-PatchSet: 1
Gerrit-Owner: tnt <tnt@246tNt.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-MessageType: merged