Attention is currently required from: osmith, Hoernchen, pespin.

Patch set 2:Code-Review +2

View Change

2 comments:

• Patchset:

  • Patch Set #1:

    (oh I thought CR -1 was for patchset 2 ... […]

    ("==" looks wrong "[" is test, and in man test one can see that "=" should be used to compare strings. Maybe test accepts both...)

• Patchset:

  • Patch Set #2:

    This is far better to read. As far as I can see it should be correct, however I didn't verify it locally but I am sure you did that.

To view, visit change 32728. To unsubscribe, or for help writing mail filters, visit settings.