Attention is currently required from: osmith, laforge, pespin, fixeria.
Patch set 6:Code-Review +2
2 comments:
File include/osmocom/bsc_nat/subscr_conn_fsm.h:
(doesn't the linter complain about trailing blank lines?)
File src/osmo-bsc-nat/bssap_conn.c:
Patch Set #4, Line 47: uint8_t tag = tag_order[i];
I've looked at the osmo-hnbgw implementation, it's for ASN.1. […]
Pau is correct that it would indeed be possible to copy the part leading up to the changed IE and then copy the remaining part after the changed IE (or even memmove in the existing buffer), but i think it would be more code than the current patch set. i like the simplicity of the current patch set.
To view, visit change 27712. To unsubscribe, or for help writing mail filters, visit settings.