pespin submitted this change.

View Change


Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, but someone else must approve laforge: Looks good to me, approved
rlcmac: Release pending polls in pdch_ul when freeing tbf

Otherwise the events are eventually sheduled and they point to an
already freed TBF.

Change-Id: I2b39ca8e79125eb2f496a92259c09c050e1f369b
---
M src/rlcmac/tbf.c
1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/src/rlcmac/tbf.c b/src/rlcmac/tbf.c
index c18ad83..524740d 100644
--- a/src/rlcmac/tbf.c
+++ b/src/rlcmac/tbf.c
@@ -27,6 +27,7 @@
#include <osmocom/gprs/rlcmac/tbf_ul.h>
#include <osmocom/gprs/rlcmac/gre.h>
#include <osmocom/gprs/rlcmac/rlcmac_enc.h>
+#include <osmocom/gprs/rlcmac/pdch_ul_controller.h>

void gprs_rlcmac_tbf_constructor(struct gprs_rlcmac_tbf *tbf,
enum gprs_rlcmac_tbf_direction direction,
@@ -38,7 +39,9 @@

void gprs_rlcmac_tbf_destructor(struct gprs_rlcmac_tbf *tbf)
{
-
+ unsigned int i;
+ for (i = 0; i < ARRAY_SIZE(g_ctx->sched.ulc); i++)
+ gprs_rlcmac_pdch_ulc_release_tbf(g_ctx->sched.ulc[i], tbf);
}

void gprs_rlcmac_tbf_free(struct gprs_rlcmac_tbf *tbf)

To view, visit change 32020. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: libosmo-gprs
Gerrit-Branch: master
Gerrit-Change-Id: I2b39ca8e79125eb2f496a92259c09c050e1f369b
Gerrit-Change-Number: 32020
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-MessageType: merged