neels submitted this change.

View Change

Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved
check rc of osmo_use_count_get_put()

Related: CID#307540 CID#307526
Change-Id: Iff450898618ce650ea1f4caa6c3d318e71485ffd
---
M src/osmo-upf/up_peer.c
M src/osmo-upf/up_session.c
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/osmo-upf/up_peer.c b/src/osmo-upf/up_peer.c
index 2c2eda1..6039b6a 100644
--- a/src/osmo-upf/up_peer.c
+++ b/src/osmo-upf/up_peer.c
@@ -188,7 +188,7 @@
m->ctx.peer_fi = peer->fi;
m->ctx.peer_use_count = &peer->use_count;
m->ctx.peer_use_token = (m->rx ? UP_USE_MSG_RX : UP_USE_MSG_TX);
- osmo_use_count_get_put(m->ctx.peer_use_count, m->ctx.peer_use_token, 1);
+ OSMO_ASSERT(osmo_use_count_get_put(m->ctx.peer_use_count, m->ctx.peer_use_token, 1) == 0);
}

struct osmo_pfcp_msg *up_peer_init_tx(struct up_peer *peer, struct osmo_pfcp_msg *in_reply_to,
diff --git a/src/osmo-upf/up_session.c b/src/osmo-upf/up_session.c
index fae4c1e..0c2f103 100644
--- a/src/osmo-upf/up_session.c
+++ b/src/osmo-upf/up_session.c
@@ -48,7 +48,7 @@
m->ctx.session_fi = session->fi;
m->ctx.session_use_count = &session->use_count;
m->ctx.session_use_token = (m->rx ? UP_USE_MSG_RX : UP_USE_MSG_TX);
- osmo_use_count_get_put(m->ctx.session_use_count, m->ctx.session_use_token, 1);
+ OSMO_ASSERT(osmo_use_count_get_put(m->ctx.session_use_count, m->ctx.session_use_token, 1) == 0);
}

enum up_session_fsm_state {

To view, visit change 31160. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmo-upf
Gerrit-Branch: master
Gerrit-Change-Id: Iff450898618ce650ea1f4caa6c3d318e71485ffd
Gerrit-Change-Number: 31160
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-MessageType: merged