fixeria submitted this change.

View Change

Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve
bts: simplify f_tc_rsl_ms_pwr_ctrl()

Change-Id: I67968a0398f9957dc4cc9c7fdffaf2b0ac40b88a
---
M bts/BTS_Tests.ttcn
1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn
index 8c05bb3..b49cb28 100644
--- a/bts/BTS_Tests.ttcn
+++ b/bts/BTS_Tests.ttcn
@@ -3831,8 +3831,6 @@
* the BTS is forwarding those values to the MS via the SACCH L1 header. */
private function f_tc_rsl_ms_pwr_ctrl(charstring id) runs on ConnHdlr {
var SacchL1Header l1h;
- var RSL_IE_MS_Power ms_power;
- var RSL_Message rsl;
var uint5_t power_level := 0;

f_l1_tune(L1CTL);
@@ -3840,16 +3838,11 @@

f_est_dchan();

- ms_power.reserved := 0;
- ms_power.fpc_epc := false;
-
/* Send the first power control command. This will disable any BTS/TRX
* internal power control and switch the MS (which is not in scope of
* this test) to a constant power level. We start with a power level
* of 0 */
- ms_power.power_level := power_level;
- rsl := valueof(ts_RSL_MS_PWR_CTRL(g_chan_nr, ms_power));
- RSL.send(rsl);
+ RSL.send(ts_RSL_MS_PWR_CTRL(g_chan_nr, ts_RSL_IE_MS_Power(power_level)));

alt {
[] as_l1_sacch_l1h(l1h, do_apply := false) {
@@ -3862,9 +3855,7 @@
/* Signal a new power level via RSL for the next turn. */
if (power_level < 31) {
power_level := power_level + 1;
- ms_power.power_level := power_level;
- rsl := valueof(ts_RSL_MS_PWR_CTRL(g_chan_nr, ms_power));
- RSL.send(rsl);
+ RSL.send(ts_RSL_MS_PWR_CTRL(g_chan_nr, ts_RSL_IE_MS_Power(power_level)));
repeat;
}


To view, visit change 39877. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I67968a0398f9957dc4cc9c7fdffaf2b0ac40b88a
Gerrit-Change-Number: 39877
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>