Attention is currently required from: fixeria, osmith.
View Change
1 comment:
Patchset:
Patch Set #4:
Given current state of osmo-sgsn I'd say this patch deserves an existing TTCN-3 test covering the scenario it fixes, specially given current complexity of tearing down stuff in there.
And yes, I know you added a unit test crafting the mmctx manually and so on, but that's not useful enough given the code base imho.
To view, visit change 42594. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Change-Id: I20c1f5f741275115635188b2f4b1c5fe7c6e40f1
Gerrit-Change-Number: 42594
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-CC: lynxis lazus <lynxis@fe80.eu>
Gerrit-Attention: osmith <osmith@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Wed, 26 Aug 2026 08:02:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No