Attention is currently required from: laforge, pespin, fixeria, daniel.
Patch set 3:Code-Review +1
View Change
1 comment:
File src/core/select.c:
Patch Set #2, Line 234: fprintf(stderr, "osmo_fd_unregister(fd=%u) out of expected range (0..%u), fix your code!!!\n",
I didn't find any osmocom log function here, only fprintf, so I assumed we want to keep osmo_log out […]
Ack
To view, visit change 31903. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: If77b84d603a42a216d550d9708eb62f645634a61
Gerrit-Change-Number: 31903
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann@sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: daniel <dwillmann@sysmocom.de>
Gerrit-Comment-Date: Tue, 14 Mar 2023 11:44:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith@sysmocom.de>
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Gerrit-MessageType: comment