Attention is currently required from: dexter, laforge.

View Change

2 comments:

• File pySim/global_platform/__init__.py:

  • Patch Set #1, Line 871: load_parser.add_argument('--chunk-len', type=auto_uint8, default=None,

    (cosmetic, no blocker) as far as I know the default is always None, no need to set it explicitly.

    I wanted to make sure that auto uint8 as None is a deliberate default, not accidental implicit None.

• File pySim/global_platform/scp.py:

  • Patch Set #1, Line 195: # is one byte less than the largest block-size multiple within 255 - mac_len.

    Would be nice to have a spec reference here (for the interested reader).

    there you go, it's just standard aes...

To view, visit change 43172. To unsubscribe, or for help writing mail filters, visit settings.