Attention is currently required from: fixeria, laforge, lynxis lazus.

View Change

2 comments:

• File pySim-shell.py:

  • Patch Set #4, Line 66:

    from pySim.ts_31_102 import ADF_USIM
    from pySi
    

    you're importing but not using these?

    Those are from my previous approach, they are indeed not used anymore.

  • Patch Set #4, Line 605: parent = self._cmd.lchan.selected_file.get_selectables()[".."]

    may be worth moving this into a separate function, to improve readability

    We can just use the .parent property of the file (I didn't see that at first).

To view, visit change 34884. To unsubscribe, or for help writing mail filters, visit settings.