Attention is currently required from: fixeria, laforge, osmith.
View Change
1 comment:
File src/stream_cli.c:
Patch Set #5, Line 983: %u
`%d` here and below? Can it be negative?
AS of now in theory the priorities are positive (stored as a u32 in the kernel) but since the setsockopt API gets passed an integer I think it's fine leaving it as an integer. We are only using some lower natural values anyway...
To view, visit change 38827. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: Ie5954fcf7eb1276210a99baf1e445c7ad54e0bb4
Gerrit-Change-Number: 38827
Gerrit-PatchSet: 5
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: osmith <osmith@sysmocom.de>
Gerrit-Attention: osmith <osmith@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Mon, 25 Nov 2024 10:10:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>