Attention is currently required from: dexter.

Patch set 2:Code-Review +2

View Change

1 comment:

• File src/osmo-hnbgw/mgw_fsm.c:

  • Patch Set #2, Line 785: if (!map->mgw_fi)

    A missing MGW FSM in this situation might be a problem still. […]

    I disagree here. The common pattern I am thinking of here is: when cleaned up, NULL the pointer.

    So mgw_fi being NULL is not a problem, it is simply the indicator that it was already cleaned up (or never existed). This apparently does occur during real operation -- an mgw_fi was already cleaned up when we call mgw_fsm_release().

To view, visit change 30688. To unsubscribe, or for help writing mail filters, visit settings.