Attention is currently required from: jolly.

View Change

5 comments:

• Patchset:

  • Patch Set #1:

    I thin you somehow confused immediateEnableFlag and refreshFlag. I also thought for a brief moment that the refreshFlag would be something that the eUICC stores, but that is not the case. The refreshFlag is something that is configured in the IoT device. This also makes sense since different modems and devices may behave differently and so some may require a REFRESH and some may not.

    I think this is easy to fix, just drop the changes in context.h and add a request struct you can pass as req to ipa_es10b_immediate_enable() and then you use the refresh_flag from the cfg struct you find in ipad.h.

    (however, I must confess that I have not understood everything in detail yet, especially when to grant/deny the immediate enable - but I think this is not in scope of this patch anyway.)

• Commit Message:

  • Patch Set #1, Line 9: Ich weiss nicht die Bohne, was das hier soll. TBD!!!

    With the refreshFlag you can control if the eUICC shall use a proactive REFRESH command to make sure that the modem re-reads all the file contents it may have cached etc.

    
    You can find more about the REFRESH command in ETSI TS 102 223, section 6.4.7

• File src/ipa/libipa/context.h:

  • Patch Set #1, Line 35: bool refresh;

    As far as I can see you do not need this flag. The ConfigureImmediateProfileEnablingRequest nor the configureImmediateEnable PSMO can set a refreshFlag directly inside the eUICC.

• File src/ipa/libipa/es10b_immediate_enable.c:

  • Patch Set #1, Line 157: enable_prfle_req.req.refreshFlag = ctx->nvstate.iot_euicc_emu.immediate_enable.refresh;

    I think this is not entirely correct. You have define a request struct in es10b_immediate_enable.h like:

    struct ipa_es10b_immediate_enable_req {
    bool refreshFlag
    }

    
    I have written a follow up message in Id750b2f5ca6c08a013aa30f876aa37e6291a30d5 at the position where ipa_es10b_immediate_enable() is called.

    
    (in SGP.32 v.1.0.1 this function had no parameters at all, that is why there is no request struct yet)

  • Patch Set #1, Line 167: IPA_LOGP_ES10X("ImmediateEnable", LINFO,

    You could split this of in a separate patch as it is unrelated.

To view, visit change 43026. To unsubscribe, or for help writing mail filters, visit settings.