Attention is currently required from: pespin.

View Change

1 comment:

• File src/tbf.h:

  • Patch Set #1, Line 260: state_fi

    It's not the "main" tbf, it's the "state" tbf as its name indicates.

    FSMs are all about states, so "state FSM/FI" sounds like "butter oil" to me :P

    What I meant is that the tbf_fsm exists during the whole lifetime of a TBF (so we can call it 'main'), while both ul_ass_fsm and dl_ass_fsm serve their purpose during the assignment period and remain no-op once the assignment is completed.

    In theory both ul_ass_fsm and dl_ass_fsm can be children FSMs of the tbf_fsm, but of course you would still need to expose their *fi pointers in order to send events to them.

    Why allocating the context dynamically if it can be allocated as part of the tbf struct? there's no need for that.

    Because this way you're exposing the internal data of the FSMs, which should not be directly accessible by anything else than the FSMs themselves. I have to admit that we do a similar trick with the bitvec's internal data array, so this is not super critical. But still a bit weird. Maybe move those internals to the private/protected part and only expose the *fi pointers?

    Anyways, not gonna block your patchset.

To view, visit change 30216. To unsubscribe, or for help writing mail filters, visit settings.