Attention is currently required from: laforge, pespin.
3 comments:
File include/osmo-bts/rtp_abstract.h:
Patch Set #3, Line 50: struct sockaddr_in local_addr;
struct osmo_sockaddr, so we support IPv6 too.
Please see my comment in the main IPv6 thread.
File src/common/rtp_abstract.c:
Patch Set #3, Line 97: rc = inet_aton(ipstr, &rs->local_addr.sin_addr);
osmo_sockaddr_from_str_and_uint(), so we support ipv6 too.
Please see my comment in the main IPv6 thread.
Patch Set #3, Line 109: const struct in_addr *ip, uint16_t port)
well, I think the Abis-over-IP protocol doesn't even contain features to use IPv6 addresses for the […]
I don't know whether ortp itself supports IPv6 or not - perhaps it does, especially in later versions - but the important bit is that osmo_ortp layer used by OsmoBTS is IPv4 only, and so is all existing OsmoBTS code operating on that "RTP socket" layer.
I would like to push back on Pau's demand to sprinkle osmo_sockaddr into the present patch and the one that follows, in places where these constructs were never used before. The "RTP abstraction layer" introduced here is purely internal to OsmoBTS application, it is not any kind of actual library, hence there are no stable API or ABI considerations of any kind. In the spirit of each individual patch changing one thing at a time, if conversion to IPv6-capable intra-OsmoBTS APIs is desired, it should be separate from the present patch which merely expands RTP library support from osmo_ortp only to either osmo_ortp or osmo_twrtp. Also if expansion to IPv6-capable operation is desired, it should probably be done after the already planned full removal of ortp, rather than before, to reduce complexity.
To view, visit change 42165. To unsubscribe, or for help writing mail filters, visit settings.