Attention is currently required from: neels, pespin.

View Change

1 comment:

• File src/host/layer23/src/mobile/gsm48_cc.c:

  • Patch Set #1, Line 54: if (cc->mncc_upqueue.next != NULL)

    Ack

    Using llist_empty() means doing this:

      if (!(cc->mncc_upqueue.next == &cc->mncc_upqueue))

    so when gsm48_cc_init() is called for the first time:

      if (!(NULL == &cc->mncc_upqueue)) // some random address from heap

    this condition will be true, and we will return early. This is wrong.

To view, visit change 30963. To unsubscribe, or for help writing mail filters, visit settings.