Attention is currently required from: fixeria.
Patch set 3:Code-Review +1
View Change
1 comment:
Patchset:
Patch Set #3:
I agree the way the gotos and labels are used in those functions is not nice at all, since they are not used as ordered return paths (catch/except style).
So I'm in favour of removing those. I cannot say the patch is fine, but I guess Vadim himself is the one knowing this the best, so +1 from my side.
To view, visit change 36915. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I5292abf6fcd308c9f7f12c7145d004103c9c7675
Gerrit-Change-Number: 36915
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-CC: laforge <laforge@osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Wed, 12 Jun 2024 18:15:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment