Attention is currently required from: fixeria.
Patch set 2:Code-Review -1
View Change
1 comment:
Patchset:
Patch Set #2:
i still think I'd rather avoid adding LOGP() to a protocol coding implementation, because all callers have to use osmo logging then... that's also why there is no LOGP() in my recently implemented libosmo-gtlv and libosmo-pfcp implementations -- by using an error cb instead, the API caller can choose whether to use osmo logging or be independent from it.
To view, visit change 30581. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Idd9c490e7a2d37817004590629092c4bb6f2d758
Gerrit-Change-Number: 30581
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-CC: msuraev <msuraev@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Sat, 25 Feb 2023 01:36:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment