Attention is currently required from: pespin.

View Change

3 comments:

• File src/osmo-bsc/paging.c:

  • Patch Set #3, Line 210: struct gsm_paging_request, entry);

    Alignment needs to be fixed.

  • Patch Set #3, Line 243: } while (request != initial_request && num_paged < MAX_PAGE_REQ_PER_ITER);

    I am trying to understand how this is supposed to work if you have less than 20 penging requests awaiting in the queue. If we have just one request, then 'request == initial_request' is true, and we break the loop - so far so good. But if we have two? I may be missing something, but AFAIU the loop will schedule 20 paging messages for just 2 requests, 10 times each. Is this the case?

  • Patch Set #3, Line 246: sched_next_paging

    This label name is confusing: when I saw the 'goto' above I thought you're somehow scheduling/sending paging in the absence of the OML link. The old name was cleaner IMO, so I would keep it. Or maybe 'sched_next_iter'?

To view, visit change 27885. To unsubscribe, or for help writing mail filters, visit settings.