Attention is currently required from: biocape, dexter.

Patch set 1:Code-Review +1

View Change

1 comment:

• File src/osmocom/utils.py:

  • Patch Set #1, Line 121: int.from_bytes(packed, byteorder='little')

    I like the approach, but there is a problem here: `int.from_bytes()` with `byteorder='little'` will drop any trailing 0x00 bytes in the stream. It's probably safe for the Network Name IE, but this function may also be used for general GSM 7-bit unpacking where data can end in zeros (like SMS text). You can append a dummy byte before converting to prevent bit-shifting into empty padding:

    ```suggestion
        packed_int = int.from_bytes(packed + b'\x01', byteorder='little')
    ```

To view, visit change 43371. To unsubscribe, or for help writing mail filters, visit settings.