Attention is currently required from: dexter.

Patch set 12:Code-Review -1

View Change

4 comments:

• Patchset:

  • Patch Set #12:

    CR-1 due to wrong pointer arithmetic.

• File src/common/pcu_sock.c:

  • Patch Set #12, Line 670: imsi

    This array can be moved to the respective scope of use now.

  • Patch Set #12, Line 680: struct gsm48_imm_ass *gsm48_imm_ass

    `const` please

  • Patch Set #12, Line 683: (struct gsm48_imm_ass *)data_req->data + 3

    This looks wrong to me. Without braces the `+ 3` is not "skip three bytes", but actually "skip three sizeof(struct gsm48_imm_ass)". gdb confirms this:

    ```
    (gdb) p (struct gsm48_imm_ass *)0x00
    $6 = (struct gsm48_imm_ass *) 0x0
    (gdb) p (struct gsm48_imm_ass *)0x00 + 3
    $7 = (struct gsm48_imm_ass *) 0x24
    (gdb) p/x sizeof(struct gsm48_imm_ass) * 3
    $8 = 0x24
    ```

    It should be:

    ```
    gsm48_imm_ass = (struct gsm48_imm_ass *)&data_req->data[3];
    ```

    or

    ```
    gsm48_imm_ass = (struct gsm48_imm_ass *)(data_req->data + 3);
    ```

To view, visit change 32734. To unsubscribe, or for help writing mail filters, visit settings.