Attention is currently required from: daniel.

View Change

1 comment:

• File src/libosmo-mgcp/mgcp_msg.c:

  • Patch Set #2, Line 172: * \returns 0 when parsing was successful, negative (MGCP cause code) on error. */

    The error returns here are not negative. […]

    regarding negative returns: I actually took the idea from already existing mgcp_verify_ci(). It's true though that mgcp_parse_header() returns them in negative values.

    regarding defines for protocol errors, I'll really skip that now and leave it to somebody else (or me) for the future, since I'm already refactoring quite a lot of stuff and I try to leave the error paths as similar as possible.

To view, visit change 39224. To unsubscribe, or for help writing mail filters, visit settings.