neels submitted this change.

View Change

Approvals: Jenkins Builder: Verified neels: Looks good to me, approved
fix sdp_msg_to_sdp_str(), never add fmtp for unset codec

Change-Id: I1892efd9360585f98419ebbd0df180f7f3a8160d
---
M src/libmsc/sdp_msg.c
1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/src/libmsc/sdp_msg.c b/src/libmsc/sdp_msg.c
index 97e871b..49fc5d2 100644
--- a/src/libmsc/sdp_msg.c
+++ b/src/libmsc/sdp_msg.c
@@ -268,11 +268,10 @@

/* Add details for all codecs */
foreach_sdp_audio_codec(codec, &sdp->audio_codecs) {
- if (codec->subtype_name[0]) {
- OSMO_STRBUF_PRINTF(sb, "a=rtpmap:%d %s/%d\r\n", codec->payload_type, codec->subtype_name,
- codec->rate > 0? codec->rate : 8000);
- }
-
+ if (!sdp_audio_codec_is_set(codec))
+ continue;
+ OSMO_STRBUF_PRINTF(sb, "a=rtpmap:%d %s/%d\r\n", codec->payload_type, codec->subtype_name,
+ codec->rate > 0 ? codec->rate : 8000);
if (codec->fmtp[0])
OSMO_STRBUF_PRINTF(sb, "a=fmtp:%d %s\r\n", codec->payload_type, codec->fmtp);
}

To view, visit change 30111. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I1892efd9360585f98419ebbd0df180f7f3a8160d
Gerrit-Change-Number: 30111
Gerrit-PatchSet: 4
Gerrit-Owner: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-MessageType: merged