Attention is currently required from: neels.

View Change

4 comments:

• File include/osmocom/tlv/tlv.h:

  • Patch Set #2, Line 56: struct osmo_tlv_cfg {

    why not storing here "instance_present = true/false", then you don't need to specify for each and every TLV you parse and write? I don't think this changes during the same protocol. It really matches here also the "tl_min_size" below since it affects it.
    Even better, have a "instance_size" which is > 0 if present, and 0 otherwise.
    You can even then drop the struct osmo_tlv_tag_inst struct and pass "t" and "i" as different params. If protocol doesn't use "i", pass whatever it will be ignored vased on "instance_size == 0".

• File src/libosmo-tlv/tlv_gen.c:

  • Patch Set #2, Line 36: const struct osmo_tlv_gen_ie osmo_tlv_gen_ie_auto = {0};

    This looks not related to this commit.

  • Patch Set #2, Line 320: printi("{}\n");

    not related to this commit?

  • Patch Set #2, Line 358: printf("\t{}\n};\n");

    not related to this commit?

To view, visit change 27529. To unsubscribe, or for help writing mail filters, visit settings.