Attention is currently required from: dexter, jolly.

Patch set 1:Code-Review -1

View Change

1 comment:

• Patchset:

  • Patch Set #1:

    Usually all misc files go to the `priv` directory - this is a standard place for auxiliary files in OTP applications. Its path can be obtained at run-time via `code:priv_dir/1`:

    ```
    -spec get_priv(Name) -> Path
        when Name :: file:filename_all(),
             Path :: file:filename_all().
    get_priv(Name) ->
        PrivDir = code:priv_dir(?ENV_APP_NAME),
        filename:join(PrivDir, Name).

    
    %% example
    Path = get_priv("sample_ssl_cert.crt").

    ```

    The proposed patch looks wrong to me.
    The configuration should definitely not contain relative paths.

To view, visit change 42830. To unsubscribe, or for help writing mail filters, visit settings.