Attention is currently required from: neels, laforge, fixeria, pespin, msuraev.

View Change

5 comments:

• Commit Message:

  • Patch Set #13, Line 10: * properly handle OOM

    OOM is not the responsibility of functions like snprintf(), the caller shall check rc < len

    Done

• File src/core/socket.c:

  • Patch Set #13, Line 229: const struct sockaddr *addr = &(*addrs)[i];

    to conform with typical osmo style, suggest using struct osmo_sockaddr instead, and below use addr. […]

    Simply changing addr type to "const struct osmo_sockaddr *" leads to memory corruption. Perhaps that's because we're casting from double pointer (we receive array of sockaddr structs)? Did I misunderstood your suggestion?

  • Patch Set #13, Line 244: OSMO_STRBUF_PRINTF(*sb, "%s%s", oss->ip, after);

    no need to use osmo_sockaddr_str here, instead do […]

    We can't use osmo_sockaddr_to_str_buf2 because it always prints port in addition to host. I've added similar function in preceeding patch.

  • Patch Set #13, Line 252: return -ENOSPC;

    do not size check!! this breaks the osmo_strbuf usage. […]

    Done

  • Patch Set #13, Line 260:

    just put the function block of multiaddr_strbuf() in here. […]

    Done

To view, visit change 28993. To unsubscribe, or for help writing mail filters, visit settings.