Attention is currently required from: neels, pespin, fixeria.
View Change
2 comments:
File src/bts.h:
Patch Set #16, Line 284: bool use_dt_confirm;
what does "dt" mean?
DT stands für "Direct TLLI" that refers to a way where we directly transfer the TLLI instead of using a payload that just contains the TLLI.
File src/pcu_l1_if.cpp:
Patch Set #5, Line 320: data[sizeof(tlli) + (PAGING_GROUP_LEN - 1 - i)]
i also dislike the pattern of unreadable encoding magic, especially in the middle of flow control an […]
Ye have discussed this today. I will add a struct for that.
To view, visit change 31145. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I2a78651593323e8b9627c39918d949a33497b70f
Gerrit-Change-Number: 31145
Gerrit-PatchSet: 17
Gerrit-Owner: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-CC: neels <nhofmeyr@sysmocom.de>
Gerrit-Attention: neels <nhofmeyr@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Mon, 27 Feb 2023 19:50:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: neels <nhofmeyr@sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>
Comment-In-Reply-To: dexter <pmaier@sysmocom.de>
Gerrit-MessageType: comment