Attention is currently required from: laforge, dexter.

Patch set 1:Code-Review -1

View Change

3 comments:

• File library/RLCMAC_CSN1_Types.ttcn:

  • Patch Set #1, Line 946: fdd_arfcn_presence

    This definition is not entirely correct. Below is my understanding of TS 44.060:

    • if this bit is `'0'B`, then neither `fdd_arfcn` nor the other FDD related fields are present, i.e. the next field in the bitstream would be `tdd_arfcn_presence`;
    • if this bit is `'1'B`, then both `fdd_arfcn` and `scrambling_code` and at least `bandwith_fdd_presence` are present in the bitstream.

    Taking this into account, your definition should look as follows:

    ```
    type record UtranTargetCellFdd {
    	uint14_t	arfcn,
    	BIT1		bandwith_presence,
    	uint3_t		bandwith optional,
    	uint10_t	scrambling_code
    } with {
    	variant (bandwith) "PRESENCE(bandwith_presence = '1'B)"
    };

    type record UtranTargetCellTdd {
    	uint14_t	arfcn,
    	BIT1		bandwith_presence,
    	uint3_t		bandwith optional,
    	uint7_t		cell_parameter,
    	BIT1		sync_case
    } with {
    	variant (bandwith) "PRESENCE(bandwith_presence = '1'B)"
    };

    type record UtranTargetCell {
    	BIT1			fdd_presence,
    	UtranTargetCellFdd	fdd optional,
    	BIT1			tdd_presence,
    	UtranTargetCellTdd	tdd optional,
    	uint6_t		reporting_quantity
    } with {
    	variant (fdd) "PRESENCE(fdd_presence = '1'B)"
    	variant (tdd) "PRESENCE(tdd_presence = '1'B)"
    };
    ```

  • Patch Set #1, Line 972: "LENGTHTO(reporting_quantity)"

    Note that `n_3g := 0` means that `reporting_quantity` contains 1 element. This should actually be: `LENGTHTO(reporting_quantity) - 1`.

  • Patch Set #1, Line 1001: utran_ba_used

    missing `optional`

To view, visit change 32995. To unsubscribe, or for help writing mail filters, visit settings.