Attention is currently required from: neels, laforge, dexter.

View Change

10 comments:

• File src/libmsc/msc_vgcs.c:

  • Patch Set #14, Line 179: OSMO_ASSERT(l3_msg);

    this would abort the program on an encoding error? […]

    Done

  • Patch Set #14, Line 231: *callref = ntohl(*(uint32_t *)ie) >> 5;

    maybe better use osmo_load32be() because it also works reliably when the pointer is not on a word bo […]

    Done

  • Patch Set #14, Line 801: if (msc_a) {

    (early exit pattern: 'if (!msc_a) return;' means less indent. […]

    Done

  • Patch Set #14, Line 1628: OSMO_ASSERT(l3_msg);

    encoding error: do not abort the program, log and return error

    Done

  • Patch Set #14, Line 1666: OSMO_ASSERT

    .

    Done

  • Patch Set #14, Line 1727: osmo_fsm_inst_free(bss->fi);

    rather use osmo_fsm_inst_term(). It terminates the instance gracefully and then frees it. […]

    Done

  • Patch Set #14, Line 1730: talloc_free(bss);

    (hint, in case you like it too, i like to allocate the struct as a talloc child of the FSM instance, […]

    Ok, makes sense. (Alternatively one could do the talloc_free inside the destructor of the the FSM, if the FSM is a child of the allocated structure.)

  • Patch Set #14, Line 1796: OSMO_ASSERT

    .

    Done

  • Patch Set #14, Line 1938: OSMO_ASSERT

    .

    Done

  • Patch Set #14, Line 1949: OSMO_ASSERT

    .

    Done

To view, visit change 33511. To unsubscribe, or for help writing mail filters, visit settings.