Attention is currently required from: fixeria, pespin, dexter.
View Change
1 comment:
Patchset:
Patch Set #1:
The flags were once internal flags. The approach changed. […]
it might make sense to state this in the documentation for those new flags. Right now it says "supports" which could mean Rx, Tx or both. I guess most people would assume both directions if it's not explicitly statesd. You could even rename the flag to FEAT_RX_SPEECH_* or FEAT_SPEECH_RX_* to state it is about RTP receive and not about transmit.
To view, visit change 31415. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I05e4ed7a85f3a0451de7cd07380503a7ac76d043
Gerrit-Change-Number: 31415
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy@sysmocom.de>
Gerrit-CC: laforge <laforge@osmocom.org>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Attention: dexter <pmaier@sysmocom.de>
Gerrit-Comment-Date: Thu, 23 Feb 2023 17:12:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Comment-In-Reply-To: dexter <pmaier@sysmocom.de>
Gerrit-MessageType: comment