Attention is currently required from: laforge, osmith, pespin.

View Change

2 comments:

• Commit Message:

  • Patch Set #1, Line 17: flag (default auto), so that building the rest of osmocom-bb doesn't

    I agree with @pespin@sysmocom. […]

    Removed the `auto`. `yes` is now the default.

• File contrib/jenkins.sh:

  • Patch Set #1, Line 29: osmo-build-dep.sh osmo-trx "" --disable-doxygen --disable-multi-arfcn --without-proxy

    AFAIU since we are adding new configure flag, we should change the jenkins. […]

    `--without-proxy` is a configure flag of osmo-trx (not osmocom-bb) and I am passing it to speed up the build (we only need libosmo-trx and could also skip more unneeded stuff). I see no reason to add a configuration matrix for a configure flag of a library that we depend on.

    If you meant `--with-trxcon` / `--without-trxcon`, I don't think it's worth it. I've tested manually that the trxcon binary does not show up (and that libosmo-trx dependency is not enforced) when `--without-trxcon` or `--with-trxcon=no` is passed.

To view, visit change 43828. To unsubscribe, or for help writing mail filters, visit settings.