13 comments:
File src/sgsn/gprs_gmm.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21545):
Patch Set #1, Line 2568: if (mmctx) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21545):
Patch Set #1, Line 2597: if (!mme) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21545):
Patch Set #1, Line 2627: } else {
else is not generally useful after a break or return
File src/sgsn/gprs_rau_fsm.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21545):
Patch Set #1, Line 365: .in_event_mask = S(GMM_RAU_E_UE_RAU_REQUEST) | S(GMM_RAU_E_GGSN_UPD_RESP) | S(GMM_RAU_E_VLR_RAU_REJECT) | S(GMM_RAU_E_VLR_TERM_SUCCESS)| S(GMM_RAU_E_VLR_TERM_FAIL),
need consistent spacing around '|' (ctx:VxW) (or typedef missing in osmo-ci/lint/checkpatch/typedefs_osmo.txt?)
File src/sgsn/sgsn_libgtp.c:
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21545):
Patch Set #1, Line 190: if (!ggsn->gsn) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21545):
Patch Set #1, Line 913: #define CHECK_SPACE_ERR(bytes) \
Macros starting with if should be enclosed by a do - while loop to avoid possible if/else logic defects
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21545):
Patch Set #1, Line 918: #define MEMCPY_CHK(dst, src, len) \
Macros with multiple statements should be enclosed in a do - while loop
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21545):
Patch Set #1, Line 918: #define MEMCPY_CHK(dst, src, len) \
macros should not use a trailing semicolon
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21545):
Patch Set #1, Line 1085: LOGMMCTXP(LOGL_INFO, mmctx, "Ctx will be transfered to another SGSN/MME\n");
'transfered' may be misspelled - perhaps 'transferred'?
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21545):
Patch Set #1, Line 1125: if (buf_len <= 0) {
braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21545):
Patch Set #1, Line 1139: // break;
please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21545):
Patch Set #1, Line 1378: strncpy(mmctx->imsi, imsi_str, sizeof(mmctx->imsi));
Instead of strncpy()/strcpy(), use osmo_strlcpy() or OSMO_STRLCPY_ARRAY()
Robot Comment from checkpatch (run ID jenkins-gerrit-lint-21545):
Patch Set #1, Line 1388: if (rc) {
braces {} are not necessary for single statement blocks
To view, visit change 39563. To unsubscribe, or for help writing mail filters, visit settings.