dexter submitted this change.

View Change

Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved
mnesia_db_work: use distinct logic when fetching from rest table

When the fetch function fetches a work item from the rest table, it
selects anything that where the facility is not euicc. This is
correct since anything else are indeed items that the
esipa_asn1_handler can work on (euicc is to manage internal states,
and handled differently). This will continue to work unless we
introduce another facility, however let's prevent future problems
by just using a more distinct logic to select the facilities
explcitly.

Related: SYS#8100
Change-Id: I2e42bde0c03155e7b2bcf058b20174b75e8e0d97
---
M src/mnesia_db_work.erl
1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/mnesia_db_work.erl b/src/mnesia_db_work.erl
index 3c11112..a620ffa 100644
--- a/src/mnesia_db_work.erl
+++ b/src/mnesia_db_work.erl
@@ -48,7 +48,10 @@
|| X <- mnesia:table(rest),
X#rest.eidValue == EidValue,
X#rest.status == new,
- X#rest.facility =/= euicc
+ X#rest.facility == download orelse
+ X#rest.facility == psmo orelse
+ X#rest.facility == eco orelse
+ X#rest.facility == edr
]),
Rows = qlc:e(Q),
case Rows of

To view, visit change 43658. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I2e42bde0c03155e7b2bcf058b20174b75e8e0d97
Gerrit-Change-Number: 43658
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>