Attention is currently required from: laforge, neels, pespin.
View Change
1 comment:
File src/libmsc/msc_a.c:
Patch Set #2, Line 192: osmo_timer_schedule(&msc_a->lu_delay_timer, Tval, 0);
are you sure the object cannot be destroyed in any way while the timer is set?
When calling this function, it's assumed that at least one token (`MSC_A_USE_LOCATION_UPDATING` or `'lu'`) is still keeping the `msc_a` object alive. So I don't see how can this happen while the timer is being set. Am I missing something?
To view, visit change 36760. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ic519cab55d65e47b2636124427dab1a1d80fab78
Gerrit-Change-Number: 36760
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: neels <nhofmeyr@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Fri, 10 May 2024 14:06:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Gerrit-MessageType: comment