Attention is currently required from: jolly, laforge, pespin.
View Change
1 comment:
File src/osmo_ss7_asp.c:
Patch Set #1, Line 853: ss7_asp_m3ua_tcp_srv_conn_cb
(re-opening the thread, since this was not addressed yet)
... As jolly is trying to fix that right now, I guess the half-life of this code is going to be very low.
@laforge@osmocom.org IIUC this means that this code is going to be reworked anyway once we migrate to `osmo_stream_srv_create2()` and I should not be spending time trying to reduce code duplication as was suggested by @pespin@sysmocom.de.
@andreas@eversberg.eu feel free to ping me in case of the merge conflicts with this patch!
To view, visit change 35796. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I8c76d271472befacbeb998a93bbdc9e8660d9b5d
Gerrit-Change-Number: 35796
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-CC: jolly <andreas@eversberg.eu>
Gerrit-Attention: jolly <andreas@eversberg.eu>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Wed, 14 Feb 2024 22:54:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge@osmocom.org>
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>
Gerrit-MessageType: comment