Attention is currently required from: neels.

Patch set 1:Code-Review +1

View Change

1 comment:

• File src/osmo-upf/upf_gtpu_echo.c:

  • Patch Set #1, Line 91: sendto

    this is of course a valid fix. Seeing all those hand-rolled socket operations, I'm wondering if it wouldn't make sense to migrate this over to osmo_io. For sure it's not a performance critical code path - but it would avoid having to manually have a read_cb, reading from the socket, etc.

To view, visit change 37824. To unsubscribe, or for help writing mail filters, visit settings.