Attention is currently required from: fixeria.

Patch set 2:Code-Review +1

View Change

2 comments:

• Patchset:

  • Patch Set #2:

    I think this is a good approach. In theory we could run another job on a more generic node first that checks if the job can be skipped, and then skip it in the pipeline... but that would make the pipeline longer and would be a lot more complex.

• File jobs/master-builds.yml:

  • Patch Set #2, Line 653: {check_jenkins_mark} "skip-card-test" || {timeout_cmd} ./contrib/jenkins.sh

    We could print a specific string here when skipping the job. This could then be used in the script that generates the jenkins job to show that the job was skipped instead of linking to the log, so it is more obvious:
    https://gitea.osmocom.org/osmocom/osmo-ci/src/branch/master/scripts/jenkins-gerrit/comment_generate.py

    ```suggestion
                  if {check_jenkins_mark} "skip-card-test"; then
                  	echo "GERRIT_PIPELINE_JOB_SKIPPED"
                  else
                  	{timeout_cmd} ./contrib/jenkins.sh
                  fi
    ```

To view, visit change 42661. To unsubscribe, or for help writing mail filters, visit settings.