Attention is currently required from: laforge, neels.
8 comments:
File include/osmocom/hnbgw/hnbgw.h:
Patch Set #6, Line 402: struct {
yes i mean that too. […]
Done
File src/osmo-hnbgw/hnbgw_hnbap.c:
Patch Set #6, Line 571: hnb_persistent_connected(ctx->persistent);
yes, but a hnb can be connected without being registered. (that is for a different redmine ticket) […]
It really depends on the specific event you want to track here. I would only use the "connected/disconnected" wording for SCTP/TCP layer here. If you are actually tracking the registered state, then I'd for for "registered" or "active" or alike. Up to you.
File src/osmo-hnbgw/hnbgw_vty.c:
Patch Set #9, Line 894: vty_out(vty, "%% WARNING: nft configuration changes need a restart of osmo-hnbw%s", VTY_NEWLINE);
hey! i fixed that!
Done
File src/osmo-hnbgw/nft_kpi.c:
Patch Set #6, Line 193: static const char * const nft_thread_req_type_name[] = {
i want to avoid iteration ala value_string, because all callers are entirely constants within this . […]
Done
Patch Set #6, Line 415: static int update_ctr(struct rate_ctr_group *cg, int cgidx, uint64_t *last_val, uint64_t new_val)
kk
Done
File src/osmo-hnbgw/nft_kpi.c:
Patch Set #9, Line 626: /* From here on, until we receive the next NFT_THREAD_GET_COUNTERS in this thread, the
if ever the time it takes to retrieve counters does overlap the wait time configured in timer X34, t […]
Done
Patch Set #9, Line 700: osmo_timer_setup(&g_hnbgw->nft_kpi.get_counters_timer, nft_kpi_get_counters_cb, NULL);
possible idea for the future: keep interval tracking at the worker, use osmo_timerfd_*() here, this […]
Done
Patch Set #9, Line 994: nft_kpi_get_counters_schedule();
i believe this was the result of our discussion: to wait X34 time *between* getting counters. […]
I really think we want to at least do as I described, which is really quick to implement (adding one "prev" timestamp and one timestmap subtraction).
This way logic conforms much more to what user would expect: If I configure X34 to 10000, I get updated counters every 10 seconds, not every 10+X seconds.
To view, visit change 36539. To unsubscribe, or for help writing mail filters, visit settings.