Attention is currently required from: dexter.
8 comments:
Commit Message:
Patch Set #1, Line 9: In OM2000 a separate bb_trxc MO does not exist to archive better
"does not exit. To achive"
Missing dot
Typo in "archive".
Patch Set #1, Line 10: compatibilty towards classic ABIS and its MOs lets mirror the nmstate of
Abis
let's
Patch Set #1, Line 11: the trx MO to the trxc_mo to make it look like if it were present.
BB_TRANSC MO to the RCARRIER MO
File src/osmo-bsc/abis_om2000.c:
Patch Set #1, Line 1011: switch (mo_state) {
Move this to a function: mo2nm_state(uint8_t mo_state).
Then, "nsd.new_state.availability = mo2nm_state(mo_state);"
Patch Set #1, Line 1032: duplicate_trxc_nm_state(bts, mo);
This looks wrong, you should emit signals for both NM objects not only one?
You could do something like this after emitting the signal:
if (mo->class == OM2K_MO_CLS_TRXC) {
struct gsm_nm_state *bbtransc_nm_state = nm_state = &trx->bb_transc.mo.nm_state;
/* Update current state before emitting signal: */
bbtransc_nm_state->availability = nsd.new_state.availability;
osmo_signal_dispatch(SS_NM, S_NM_STATECHG, &nsd);
}
Patch Set #1, Line 1058: duplicate_trxc_nm_state(bts, mo);
Same, simply explicitly set bb_transc_nm_state->operational = new_state.operational;
Not directly related to this patch but indirectly related to have stuff working as expected: AFAICT you are missing a "osmo_signal_dispatch(SS_NM, S_NM_STATECHG, &nsd);" here.
Patch Set #1, Line 2245: otfp->trx->bb_transc.mo.nm_state.administrative = NM_STATE_UNLOCKED;
Not directly related to this patch but indirectly related to have stuff working as expected: AFAICT you are missing a "osmo_signal_dispatch(SS_NM, S_NM_STATECHG, &nsd);" here.
To view, visit change 28896. To unsubscribe, or for help writing mail filters, visit settings.