Attention is currently required from: laforge, dexter.
Patch set 1:Code-Review -1
View Change
1 comment:
File pySim/ts_31_102.py:
Patch Set #1, Line 751: def _decode_record_hex(self, in_hex):
Something is wrong here, _decode_record_hex() must be a method of class EF_RPLMNAcT I guess, not a scoped function of __init__()? In other words, << in vim.
To view, visit change 28636. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ic7163b2a01f64ef1223cf15b8d0813d3edf5b61a
Gerrit-Change-Number: 28636
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge@osmocom.org>
Gerrit-Reviewer: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-CC: Jenkins Builder
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: dexter <pmaier@sysmocom.de>
Gerrit-Comment-Date: Sun, 17 Jul 2022 20:42:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment