Attention is currently required from: dexter, laforge.
View Change
1 comment:
File setup.py:
Patch Set #1, Line 34: smpp.twisted
This (among with many other deps) should ideally go to `extras_require`, because it's not really required for the primary `pySim-shell` tool. Not saying that it must be done in this patch, just bringing up a concern about ever growing list of dependencies.
To view, visit change 37456. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ie5bae9d823bca6f6c658bd455303f63bace2258c
Gerrit-Change-Number: 37456
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge@osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: dexter <pmaier@sysmocom.de>
Gerrit-Comment-Date: Wed, 10 Jul 2024 18:19:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment