Attention is currently required from: laforge, pespin, keith.
View Change
1 comment:
File src/input/e1d.c:
Patch Set #4, Line 123: if (bfd->list.next && bfd->list.next != LLIST_POISON1)
No, it doesn't, because osmo_fd_is_registered() can be costly, and in most ocassions you know if the […]
Indeed osmo_fd_is_registered() is a bit costly due to the list iteration.
You are also right about the fd >= 0 check. This makes sense. Thanks.
To view, visit change 32374. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Gerrit-Change-Id: Iaf4d42c2f009b1d7666e319fabdeb2598aa0b338
Gerrit-Change-Number: 32374
Gerrit-PatchSet: 8
Gerrit-Owner: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: keith <keith@rhizomatica.org>
Gerrit-CC: laforge <laforge@osmocom.org>
Gerrit-CC: pespin <pespin@sysmocom.de>
Gerrit-CC: tnt <tnt@246tNt.com>
Gerrit-Attention: laforge <laforge@osmocom.org>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Attention: keith <keith@rhizomatica.org>
Gerrit-Comment-Date: Tue, 02 May 2023 14:02:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Comment-In-Reply-To: dexter <pmaier@sysmocom.de>
Gerrit-MessageType: comment