Attention is currently required from: daniel.

5 comments:

Patchset:
- Patch Set #4:
  I'm currently lookin
File gtp/gsn.c:
- Patch Set #2, Line 558: (*gsn)->sgsn_ctx = sgsn_ctx_reqs_init(*gsn, 2048, 4095);
  I don't want to bikeshed too much, but it would be clearer to me if the function (and member variabl […]
  it also initializes the gtp tunnel endpoint ids.
  Should I rename it?
File gtp/gtp_sgsn_ctx.c:
- Patch Set #2, Line 72: OSMO_ASSERT(1);
  OSMO_ASSERT(0)? […]
  Done
File include/osmocom/gtp/gsn.h:
- Patch Set #7, Line 116: int (*cb_sgsn_context_request_ind) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size);
  I'll keep this "wrong" spaced function pointer, because all other functions in here o it as well. It should be changed all in one.
- Patch Set #7, Line 169: int (*cb) (struct gsn_t *gsn, struct sockaddr_in *peer, uint32_t local_ref, union gtpie_member **ie, unsigned int ie_size));
  I'll keep this "wrong" spaced function pointer, because all other functions in here o it as well. It should be changed all in one.

To view, visit change 38938. To unsubscribe, or for help writing mail filters, visit settings.