dexter submitted this change.

View Change

Approvals: Jenkins Builder: Verified dexter: Looks good to me, approved Hoernchen: Looks good to me, but someone else must approve
cat: Fix alpha identifier

Add implementation so that it prints.

Change-Id: I01aaeb84480c337e6328ef4e20321018525bd9d4
Signed-off-by: Eric Salem <ericsalem@gmail.com>
---
M pySim/cat.py
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/pySim/cat.py b/pySim/cat.py
index e65af3f..80cd002 100644
--- a/pySim/cat.py
+++ b/pySim/cat.py
@@ -24,7 +24,7 @@
from construct import Struct, Enum, BitStruct, this
from construct import Switch, GreedyRange, FlagsEnum, Adapter
from osmocom.tlv import TLV_IE, COMPR_TLV_IE, BER_TLV_IE, TLV_IE_Collection
-from osmocom.construct import PlmnAdapter, BcdAdapter, GsmStringAdapter, TonNpi, GsmString, Bytes, GreedyBytes
+from osmocom.construct import PlmnAdapter, BcdAdapter, GsmOrUcs2Adapter, GsmStringAdapter, TonNpi, GsmString, Bytes, GreedyBytes
from osmocom.utils import b2h, h2b
from pySim.utils import dec_xplmn_w_act

@@ -37,8 +37,7 @@

# TS 102 223 Section 8.2
class AlphaIdentifier(COMPR_TLV_IE, tag=0x85):
- # FIXME: like EF.ADN
- pass
+ _construct = GsmOrUcs2Adapter(GreedyBytes)

# TS 102 223 Section 8.3
class Subaddress(COMPR_TLV_IE, tag=0x88):

To view, visit change 43782. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: merged
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I01aaeb84480c337e6328ef4e20321018525bd9d4
Gerrit-Change-Number: 43782
Gerrit-PatchSet: 1
Gerrit-Owner: Eric Salem <ericsalem@gmail.com>
Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier@sysmocom.de>