Attention is currently required from: pespin.
2 comments:
File doc/manuals/abis/rsl.adoc:
Patch Set #1, Line 872: | 0x62 | RSL_IE_OSMO_TEMP_OVP_ACCH_CAP | <<RSL_IE_OSMO_TEMP_OVP_ACCH_CAP>>
These 2 above seem to actually be missing but not really related to this patch, so perhaps submit th […]
The current state of the doc covers IEIs up to 0x61, but libosmocore has definitions up to 0x63. I picked 0x64 for my new IE, but attempting to document 0x64 right after 0x61 makes it obvious that the documentation step got skipped for 0x62 and 0x63. But yes, I will split this part off into a separate pre-patch.
Patch Set #1, Line 1110: This information element requests the use of non-standard enhanced RTP
I'm maybe missing some sort of packetdiag output (see for instance packetdiag examples in . […]
About TLV: I am open to changing this IE to TV. For context, please read TW-TS-003:
https://www.freecalypso.org/specs/tw-ts-003-v010001.txt
TW-TS-003 defines one new IE on AoIP BSSMAP interface, and that one is of fixed-length TV format. Now we need to propagate the same signaling from the BSC to the BTS - but for Abis-IP, unlike AoIP, there are no 3GPP specs at all, hence nothing to extend with TW-TS-* specs - instead all Abis-IP definitions have to be worked out in Osmocom only.
For the Osmocom-controlled IE from OsmoBSC to OsmoBTS, my first thought was to make it TV and define it as an exact copy of TW-TS-003 on AoIP. But then I saw that all other Osmocom extension IEs, e.g., RSL_IE_OSMO_OSMUX_CID, are defined as TLV, even though Osmux CID for example is always one byte. Hence I followed suit with my new IE.
Maybe we can now decide if the new IE (that replicates TW-TS-003 on Abis-IP) should be TV or TLV, and then document it accordingly?
To view, visit change 36706. To unsubscribe, or for help writing mail filters, visit settings.