Attention is currently required from: laforge.
4 comments:
File pySim/filesystem.py:
unrelated cosmetic change. […]
Done
Patch Set #1, Line 747: if total_len is not None:
this could deserve some documentation (doc-string or comment). […]
In case the size is not specified, the default value of the parameter in the constructor should ensure size is present. Unless the constructor is called explicitly with size = None, there should be no problem. In any case, lets put a check to be 100% sure.
Patch Set #1, Line 1043: __get_rec_len
why do we have double-underscores here but single-underscore for _get_size() above? Also: please ad […]
I thought I could re-use _get_size() in TransRecEf, that is why _get_size only has one underscore.
Patch Set #1, Line 1266: return b2h(filter_dict(build_construct(self._construct, abstract_data, self._get_size(total_len))))
Did you test that? I think a _get_rec_len() would actually be required here. […]
I see, we can not use _get_size here. As far as I understand now I would have to use the rec_len as an alternative value.
I wonder how to test this. As it seems TransRecEF registers the command set from TransparentEF, so I only get the normal update_binary commands.
To view, visit change 38195. To unsubscribe, or for help writing mail filters, visit settings.