fixeria has uploaded this change for review.

View Change

trxcon/l1ctl: print an error for uhnandled DATA.req / TRAFFIC.req

Change-Id: I1d965c2882eb72dc845bea85a4ffaa26d37cee05
---
M src/host/trxcon/src/l1ctl.c
1 file changed, 9 insertions(+), 2 deletions(-)

git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/00/41900/1

diff --git a/src/host/trxcon/src/l1ctl.c b/src/host/trxcon/src/l1ctl.c
index 0f6bd1b..7ce8c3d 100644
--- a/src/host/trxcon/src/l1ctl.c
+++ b/src/host/trxcon/src/l1ctl.c
@@ -685,9 +685,16 @@
 		osmo_fsm_inst_dispatch(fi, TRXCON_EV_TX_DATA_REQ, &req);
 		break;
 	default:
-		if (!traffic && req.link_id == 0x40) /* only for SACCH */
+		if (!traffic && req.link_id == 0x40) { /* only for SACCH */
 			osmo_fsm_inst_dispatch(fi, TRXCON_EV_UPDATE_SACCH_CACHE_REQ, &req);
-		/* TODO: log an error about uhnandled DATA.req / TRAFFIC.req */
+			break;
+		}
+
+		LOGPFSMSL(fi, g_logc_l1d, LOGL_ERROR,
+			  "Unhandled %s Req (chan_nr=0x%02x, link_id=0x%02x, len=%zu): %s\n",
+			  traffic ? "TRAFFIC" : "DATA", req.chan_nr, req.link_id, req.data_len,
+			  msgb_hexdump_l2(msg));
+		break;
 	}
 
 	msgb_free(msg);

To view, visit change 41900. To unsubscribe, or for help writing mail filters, visit settings.