Attention is currently required from: arehbein.
5 comments:
Patchset:
Again this should be per BTS.
File include/osmocom/bsc/bts.h:
Patch Set #2, Line 326: #define GSM_BTS_TDEF_ID_TNS_BLOCK_NEG29 (-29)
Better leave some space in the number series so that we can later on add similar timers next to the existing ones.
File src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c:
Patch Set #2, Line 187: struct osmo_tdef *tdefs = bts->network->T_defs;
Again, this needs to be per BTS.
File src/osmo-bsc/bts_vty.c:
Patch Set #2, Line 76: static const int gprs_ns_timer_tdef_data[][2] = {
AFAICT this is only used in cfg_bts_gprs_ns_timer_cmd, so it can be moved there.
Patch Set #2, Line 1627: int idx = get_string_value(gprs_ns_timer_strs, argv[0]);
so you are converting to an index here once, and in line 1637 again. This looks ptoentially wrong. Why isn't this get_string_value providing the interesting idx directly?
To view, visit change 31880. To unsubscribe, or for help writing mail filters, visit settings.